chore(byoc): Refactor BYOC private networking setup docs#5780
Merged
duanshiqiang merged 7 commits intomainfrom Mar 28, 2026
Merged
chore(byoc): Refactor BYOC private networking setup docs#5780duanshiqiang merged 7 commits intomainfrom
duanshiqiang merged 7 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
duanshiqiang
force-pushed
the
feature-gcp-private-connect
branch
from
9f1ab77 to
7545b46
Compare
duanshiqiang
force-pushed
the
feature-gcp-private-connect
branch
from
7545b46 to
762f499
Compare
duanshiqiang
force-pushed
the
feature-gcp-private-connect
branch
from
762f499 to
0295fb4
Compare
duanshiqiang
force-pushed
the
feature-gcp-private-connect
branch
from
0295fb4 to
4e960f2
Compare
duanshiqiang
force-pushed
the
feature-gcp-private-connect
branch
from
4e960f2 to
ec9ef4a
Compare
duanshiqiang
force-pushed
the
feature-gcp-private-connect
branch
from
ec9ef4a to
b801267
Compare
duanshiqiang
force-pushed
the
feature-gcp-private-connect
branch
from
b801267 to
9c81118
Compare
duanshiqiang
force-pushed
the
feature-gcp-private-connect
branch
2 times, most recently
from
631984b to
8a9092c
Compare
duanshiqiang
force-pushed
the
feature-gcp-private-connect
branch
from
8a9092c to
56eb099
Compare
duanshiqiang
force-pushed
the
feature-gcp-private-connect
branch
from
56eb099 to
cf5b585
Compare
duanshiqiang
force-pushed
the
feature-gcp-private-connect
branch
3 times, most recently
from
e0f83c0 to
cfc6ce2
Compare
duanshiqiang
force-pushed
the
feature-gcp-private-connect
branch
from
cfc6ce2 to
6feaabc
Compare
duanshiqiang
force-pushed
the
feature-gcp-private-connect
branch
from
6feaabc to
aea5aa2
Compare
duanshiqiang
force-pushed
the
feature-gcp-private-connect
branch
from
e66d826 to
cf3310a
Compare
dhtclk
requested changes
Mar 26, 2026
Collaborator
dhtclk
left a comment
dhtclk
left a comment
There was a problem hiding this comment.
Great work, just a few comments!
...ud/guides/infrastructure/01_deployment_options/byoc/03_onboarding/03_network_setup/02_gcp.md
Outdated
Show resolved
Hide resolved
...ud/guides/infrastructure/01_deployment_options/byoc/03_onboarding/03_network_setup/02_gcp.md
Outdated
Show resolved
Hide resolved
...ud/guides/infrastructure/01_deployment_options/byoc/03_onboarding/03_network_setup/02_gcp.md
Outdated
Show resolved
Hide resolved
...ud/guides/infrastructure/01_deployment_options/byoc/03_onboarding/03_network_setup/02_gcp.md
Outdated
Show resolved
Hide resolved
...ud/guides/infrastructure/01_deployment_options/byoc/03_onboarding/03_network_setup/02_gcp.md
Outdated
Show resolved
Hide resolved
...ud/guides/infrastructure/01_deployment_options/byoc/03_onboarding/03_network_setup/02_gcp.md
Outdated
Show resolved
Hide resolved
...oud/guides/infrastructure/01_deployment_options/byoc/03_onboarding/03_network_setup/index.md
Show resolved
Hide resolved
...ud/guides/infrastructure/01_deployment_options/byoc/03_onboarding/03_network_setup/02_gcp.md
Outdated
Show resolved
Hide resolved
…_onboarding/03_network_setup/02_gcp.md Co-authored-by: Dominic Tran <dominic.tran@clickhouse.com>
…_onboarding/03_network_setup/02_gcp.md Co-authored-by: Dominic Tran <dominic.tran@clickhouse.com>
…_onboarding/03_network_setup/02_gcp.md Co-authored-by: Dominic Tran <dominic.tran@clickhouse.com>
duanshiqiang
force-pushed
the
feature-gcp-private-connect
branch
from
e6f6800 to
2c7be8f
Compare
dhtclk
requested changes
Mar 27, 2026
...oud/guides/infrastructure/01_deployment_options/byoc/03_onboarding/03_network_setup/index.md
Outdated
Show resolved
Hide resolved
...ud/guides/infrastructure/01_deployment_options/byoc/03_onboarding/03_network_setup/01_aws.md
Outdated
Show resolved
Hide resolved
...ud/guides/infrastructure/01_deployment_options/byoc/03_onboarding/03_network_setup/01_aws.md
Outdated
Show resolved
Hide resolved
...ud/guides/infrastructure/01_deployment_options/byoc/03_onboarding/03_network_setup/02_gcp.md
Outdated
Show resolved
Hide resolved
...ud/guides/infrastructure/01_deployment_options/byoc/03_onboarding/03_network_setup/02_gcp.md
Outdated
Show resolved
Hide resolved
...ud/guides/infrastructure/01_deployment_options/byoc/03_onboarding/03_network_setup/02_gcp.md
Outdated
Show resolved
Hide resolved
...ud/guides/infrastructure/01_deployment_options/byoc/03_onboarding/03_network_setup/02_gcp.md
Outdated
Show resolved
Hide resolved
...ud/guides/infrastructure/01_deployment_options/byoc/03_onboarding/03_network_setup/02_gcp.md
Outdated
Show resolved
Hide resolved
...ud/guides/infrastructure/01_deployment_options/byoc/03_onboarding/03_network_setup/02_gcp.md
Outdated
Show resolved
Hide resolved
...ud/guides/infrastructure/01_deployment_options/byoc/03_onboarding/03_network_setup/02_gcp.md
Outdated
Show resolved
Hide resolved
Figured I'd help move this along so I wasn't blocking you, these are simple capitalization and grammar changes. Co-authored-by: Dominic Tran <dominic.tran@clickhouse.com>
dhtclk
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR mainly adds GCP private networking setup besides AWS to current BYOC docs.
Checklist